ludohenin / gulp-inline-ng2-template

Gulp plugin to inline HTML and CSS into Angular 2 component decorators
MIT License
126 stars 26 forks source link

Some functions swallows error #68

Closed unlight closed 8 years ago

unlight commented 8 years ago

Which prevents catching.

See comments.

  function processStyles(done) {
    if (opts.styleProcessor) {
      CSS = true;
      extend(opts, cssOptions());
      execute(function () { // First argument is error, it should be forwarded to done()
        reset();
        done(null);
      });
    }
  }

Same in other functions: https://github.com/ludohenin/gulp-inline-ng2-template/blob/master/parser.js#L82 https://github.com/ludohenin/gulp-inline-ng2-template/blob/master/parser.js#L72

ludohenin commented 8 years ago

this is a duplicate of #60