luheng / lsgn

Labeled Span Graph Networks
Apache License 2.0
118 stars 27 forks source link

Bug in ./scripts/make_conll2012_data.sh #5

Open ghaddarAbs opened 5 years ago

ghaddarAbs commented 5 years ago

It seem that cat can't handle the large number of *.gold_conll in the train portion. The script print this warning and continue: ./scripts/make_conll2012_data.sh: line 19: /bin/ls: Argument list too long

However, changing:

https://github.com/luheng/lsgn/blob/b1495ecf559e36c5e37078c54e00a1ec6faae5b2/scripts/make_conll2012_data.sh#L19

https://github.com/luheng/lsgn/blob/b1495ecf559e36c5e37078c54e00a1ec6faae5b2/scripts/make_conll2012_data.sh#L20

to:

for file in ${ONTONOTES_PATH}/data/train/data/english/annotations/*/*/*/*.gold_conll
do
  cat "$file" >> ${SRL_PATH}/train.english.v5_gold_conll
done

solve the problem

scofield7419 commented 5 years ago

@ghaddarAbs Thank u man, your solution helps a lot.