luisiacc / gruvbox-baby

Gruvbox theme for neovim with full 🎄TreeSitter support.
MIT License
402 stars 28 forks source link

[Feature Request] Light Theme Support #17

Open shekohex opened 2 years ago

shekohex commented 2 years ago

Hey! Thank you for the theme! it looks amazing!

I was going to ask if there are any plans to support the light variant of the theme? me myself using the light theme most of the time as it is easier for my eyes to read the dark text on a light background.

I want to start working on adding support for the light theme too, but I would need some help or guidance 😄

Thank you again!

luisiacc commented 2 years ago

It wasn't in my plan to add a light theme, if you like to give it a try you can try I would totally accept an approach very similar to what is done in https://github.com/folke/tokyonight.nvim

chriscz commented 1 year ago

Hi, was also looking into a light theme since I've switched to tree-sitter for highlighting.

I have been using: https://github.com/sainnhe/gruvbox-material

However I see there is a an alternative lua gruvbox also with treesitter support https://github.com/ellisonleao/gruvbox.nvim (will give it a try and report back)

The reason I switched to light themes was because I was finding it harder and harder to read over time and though I might need glasses, but after making the switch I haven't had issues. Related articles on light vs dark mode benefits:

Edit

luisiacc commented 1 year ago

IMO gruvbox theme does not look good on light mode, only on dark mode, therefore I don't really plan to take any action myself into supporting it.