search

luisiacc / gruvbox-baby

Gruvbox theme for neovim with full 🎄TreeSitter support.
MIT License
393 stars 28 forks source link

Issue and suggestions #19

Closed chaudry-786 closed 2 years ago

chaudry-786 commented 2 years ago

Issue

1) Cursor colour is very dark and hard to see on any empty space before text. See image below

Screenshot from 2022-08-03 00-46-36

Expectation (it seems to be fine after some text)

Screenshot from 2022-08-03 00-51-15

Note: This problem is on Ubuntu terminal and Mac (iterm 2) seems to be fine.

Suggestion; I'm using CoC.nvim, CursorHold (which highlights the symbol and references) and visually highlighted text share very similar (if not same) highlight group so it's hard to tell when I'm in visual mode. I have changed it for myself but maybe this should be addressed in the colour scheme.

Overall, I'm loving this theme, I have been using gruvbox for over a year but it just didn't seem enough for Python, Lua and JS. Thank you again.

luisiacc commented 2 years ago

I have been using gruvbox for over a year but it just didn't seem enough for Python, Lua and JS.

Those were my exact thoughts when creating this theme!

Cursor colour is very dark and hard to see on any empty space before text. See image below

Personally I like it the way it is, so called it to "personal choice"

I'm using CoC.nvim, CursorHold (which highlights the symbol and references) and visually highlighted text share very similar (if not same) highlight group so it's hard to tell when I'm in visual mode.

I don't use coc, could you provide a picture of it so I can improve it?

chaudry-786 commented 2 years ago

Personally I like it the way it is, so called it to "personal choice"

Is there a simple way of changing it?

I don't use coc, could you provide a picture of it so I can improve it?

I have visually select the word under cursor but as you can see it's very similar to other reference and definition.

Screenshot from 2022-08-03 10-03-00

The highlight group for CocCursorHold is "CocHighlightText" and is linked to "CursorColumn" Screenshot from 2022-08-03 10-11-30

luisiacc commented 2 years ago

Is there a simple way of changing it?

Hmm looking closely I have no idea why it's a color before text and a color after, have you tried what happens on another terminal emulator?

chaudry-786 commented 2 years ago

No idea why, on Ubuntu I tried in and out of tmux and it still persists. Could I run some test to see what highlight group is being used there (under the cursor)?

luisiacc commented 2 years ago

Could I run some test to see what highlight group is being used there (under the cursor)?

Don't know if you can do that since there is actually nothing under the cursor.