Closed crzdg closed 1 year ago
Hi there!
It's amazing to see this, thank you! It looks really good.
One small thing: Currently the color palette is the same for all intensities, so it feels kind of repetitive to add the same palette 4 times, when it's really most of the same colors, only some changes in the background colors.
Hi there!
It's amazing to see this, thank you! It looks really good.
One small thing: Currently the color palette is the same for all intensities, so it feels kind of repetitive to add the same palette 4 times, when it's really most of the same colors, only some changes in the background colors.
I thought the same here as well. In the end, I decided to add all the images to the README
, as they all have a different (image) background color (the actually used background
-color) so you see the color palette in contrast to the background
-color. IMHO, this is important for the user so the palettes actually can be compared.
I agree that most colors are repeated, but for me, the contrast of the colors to the background is an important piece of information.
Maybe we can agree on using an expandable
(https://gist.github.com/pierrejoubert73/902cc94d79424356a8d20be2b382e1ab) for the different images?
Also, I was thinking of adding an image that shows the differences between the actually changed colors (dark
, background
, etc...). So the user can see what shades are used in the different modes.
So in the end the README will contain an image of the medium color palette in expanded mode and an image showing the different shades side-by-side. The palettes for dark
, soft
, soft_flat
will be added as well but are collapsed by default.
What do you think?
Hi there, sry for the late response, I'm traveling so I don't get much time with internet.
I agree that most colors are repeated, but for me, the contrast of the colors to the background is an important piece of information.
Yeah I agree that the contrast of the colors with the background is important, however that's visible when the colors are seen as code(like on a code screenshot), when you put them as rectangles like the way it is now, that contrast is not really appreciated(At least I didn't see any noticeable difference), after all, the objective of showing the palette is just a way for the user to be able to quickly copy/paste them, therefore having them repeated doesn't make much sense IMO.
Also, I was thinking of adding an image that shows the differences between the actually changed colors (dark, background, etc...). So the user can see what shades are used in the different modes. So in the end the README will contain an image of the medium color palette in expanded mode and an image showing the different shades side-by-side. The palettes for dark, soft, soft_flat will be added as well but are collapsed by default.
OK this sounds good!, although I remain a bit skeptical about having the colors repeated, I love the idea of having the different shades side-by-side.
Hey,
No problem.
I will push a suggestion over the weekend. Then we can have the next discussion. Maybe, we will improve it a little now, and then we do an iteration on it.
Shouldn't you upload media files somewhere else than github?
As a user of this colorscheme, I would like to not have to have the .svg
files on my machine.
As a user of this colorscheme, I would like to not have to have the .svg files on my machine.
They are 8kbs each, so you wouldn't even notice them.
@luisiacc
Sorry I was sick the last days and was not able to update this earlier.
OK, I changed quite some things with the new commits.
.gitignore
. I copied the content of the GitHub Lua and Python .gitignore
. I hope this is OK with you?README
I added emojis for all the headers. I also moved back the info about the terminal and the font back to the Pretty Pictures
section. But instead below an separate header I added it right after the Pretty Pictures
header.The main change still would be the Palette
section.
I added as you have already seen the different palettes of the intensities. But put them in a expandable.
Further, a image showing the different shades of the intensities, as discussed.
And a table with the colors, its names and hex-values.
Have a look at the README here,
https://github.com/crzdg/gruvbox-baby/tree/svg-palettes
I guess we should discuss, how the added content should be organized. The linked README
shows my proposal for it.
I'm happy to heare your idea of how it should be organized.
Hi!
I created a python script which creates the palettes of the colors for the different intensity maps.
To run you need
svgwrite
installed.This should help to maintain the README. If somebody could add an exporter of the actual lua colors to the python dict used in this script, this would be awesome. Unfortunately, I do not know any lua beyond nvim config.
Also, I rearrange the README a little bit.
Feel free to add some suggestions!
Addresses,
15 and #31
Have a look on the new README here: https://github.com/crzdg/gruvbox-baby/tree/svg-palettes