luisiacc / gruvbox-baby

Gruvbox theme for neovim with full 🎄TreeSitter support.
MIT License
402 stars 28 forks source link

extras: reorganized, added Widows Terminal, added tmux #44

Closed crzdg closed 2 years ago

crzdg commented 2 years ago

Added some extras I use myself,

crzdg commented 2 years ago

@luisiacc Do you plan to merge this at some point?

Let me know if I should change something.

luisiacc commented 2 years ago

Hi @crzdg yes I do, sry for the very late reply, this everything looks good, if you can on another PR make a script that will run all of the other scripts for the extras folder, at this point if you want you can also make a Makefile to run that script, so in a way that if I run make extras on cmd, it will regenerate all of the extras files with the latest colors.

crzdg commented 2 years ago

@luisiacc This sound like a great idea! I will try to remember it as soon I will contribute something new.

We probably also have to think of a way to add the colors of the actual Lua-files to the python dict so we don't have to update it manually. Then we have a pretty neat solution to maintain all those extras.

luisiacc commented 2 years ago

you can make a lua script to export the colors to a json file, and use the json file as a source of truth for the external scripts that are not in lua, but then on the sequence of scripts you'll have to always run the lua script first to make sure the colors are up-to-date, this is just the idea that is on the top of my mind right now, if you come up with a better one feel free to pursue it.