lumidion / sbt-sonatype-central

An sbt plugin for deploying open-source artifacts to Maven via the Sonatype Central portal
MIT License
5 stars 1 forks source link

Remove `zio-json` dependency #8

Closed KacperFKorban closed 2 months ago

KacperFKorban commented 3 months ago

Hi, thanks for creating this plugin.

As per the comment in sbt-ci-realese, adding a zio-json as a dependency adds some controversy. Would it be possible to use e.g. sjon-new, since it is already the go to json library in sbt?

Original comment (https://github.com/sbt/sbt-ci-release/pull/298#pullrequestreview-2169049028):

Does this transitively introduce Zio dependency just for JSON decoding? Could we use Contraband / sjson-new that are already in use for sbt or uPickle instead?

Andrapyre commented 2 months ago

@KacperFKorban, closing this now that https://github.com/lumidion/sonatype-central-client/pull/6 and https://github.com/lumidion/sbt-sonatype-central/pull/10 are merged with fresh releases.

KacperFKorban commented 2 months ago

Thanks! :heart: