search

lumidion / sbt-sonatype-central

An sbt plugin for deploying open-source artifacts to Maven via the Sonatype Central portal
MIT License
5 stars 1 forks source link

Use requests and upickle instead of zio-json #9

Closed KacperFKorban closed 1 month ago

KacperFKorban commented 1 month ago

closes #8

Andrapyre commented 1 month ago

@KacperFKorban , thanks for the issue/PR and sorry for the delay. If you need this for the sbt-ci-release PR that you linked, this is the wrong repo, as it isn't currently being used by sbt-sonatype. You would need to submit a PR there directly, but I'm still waiting on a comment to clarify the future vision in this thread: https://github.com/xerial/sbt-sonatype/issues/465.

It's a fair point about the transitive dependency. I would handle this slightly differently and use uPickle with sttp (I prefer sttp since it's easier to handle retries in a more granular way. For instance, I don't want to retry if we get an auth error, etc, but that's harder to do with clients that sit on top of requests, since there isn't strong typing around it like there is in sttp). Let me see if I can get a new version of the sonatype-central-client out in a day or so and then it's literally a line or two of changes here.

KacperFKorban commented 1 month ago

Thanks for the answer. I wasn't sure in which repo to do the change either, so I started here :sweat_smile: If you can add a new sttp-upickle module, that would be awesome. I think that most people would prefer lighter dependencies. I'll close this PR then.