luvmex / Sketch-Guides

Add Guides to edges and midpoints at once.
85 stars 7 forks source link

Control bar not functioning in Sketch 84 #8

Open membranophonist opened 2 years ago

membranophonist commented 2 years ago

Menu commands are working as intended. Control bar commands are not.

  1. Display the rulers
  2. Select Plugins > Sketch Guides > Launch Control Bar
  3. Select a canvas layer
  4. Click any of the guide placement buttons on the control bar
  5. Notice that the guide is not placed

macOS 12.3 Sketch 84 (build 140208) Sketch Guides 2.5.1

wilddancers commented 2 years ago

Menu commands are working as intended. Control bar commands are not.

  1. Display the rulers
  2. Select Plugins > Sketch Guides > Launch Control Bar
  3. Select a canvas layer
  4. Click any of the guide placement buttons on the control bar
  5. Notice that the guide is not placed

macOS 12.3 Sketch 84 (build 140208) Sketch Guides 2.5.1

Hi,you can fix this bug by this way: 1、Find Sketch Guides.sketchplugin from sketch plugin folder; 2、Show Guides.sketchplugin package content; 3、Follow:Sketch Guides.sketchplugin/Contents/Sketch/library/common.js,open common.js file; 4、Change code this.context.selection = this.context.document.selectedLayers().layers() —>this.context.selection = this.context.document.selectedLayers();

membranophonist commented 2 years ago

Great! Thank you for the fix.

instanttim commented 8 months ago

This can be closed... the PR was taken with the fix.