luxonis / depthai-ros

Official ROS Driver for DepthAI Sensors.
MIT License
239 stars 174 forks source link

Fix rgbd_pcl configuration #269

Closed borongyuan closed 1 year ago

borongyuan commented 1 year ago

PointCloudXyzrgbNode now support uint16 depth image, so there's no need to use ConvertMetricNode. However, PointCloudXyzrgbNode reruires rectifiec/undistored images as input. Using wrong data may not be noticed with most OAK devices. But since I'm using OAK-D Pro W, the differences are significant. Using unfixed config: rviz_screenshot_2023_04_01-13_01_14 Using correct config: rviz_screenshot_2023_04_01-13_00_11 RTAB-Map configs may have the same issue. I'll check and test later.

Serafadam commented 1 year ago

Thanks for that, I'll also change it so that this parameter is enabled by default in next PR (and rgb rectification is enabled by launch arg)