update socket logic - Githubissues

luxonis / depthai-ros

Official ROS Driver for DepthAI Sensors.

MIT License

239 stars 173 forks source link

update socket logic #400

Closed Serafadam closed 9 months ago

Serafadam commented 10 months ago

Overview

Author: @Serafadam

Issue

Issue link (if present): https://github.com/luxonis/depthai-ros/issues/396 https://github.com/luxonis/depthai-ros/issues/393 Issue description: Update sensor logic regarding board socket names and pipeline validation, add Readme information on available sensor resolutions. Related PRs: https://github.com/luxonis/depthai-ros/pull/398

Changes

ROS distro: Humble List of changes:

Move sensor names, types etc. to sensor_helpers.cpp to keep it in one place
Update setting board socked ID's as parameters to use defaults
Fix bug where pipeline type wasn't properly changed for OAK-1

Testing

Hardware used: OAK-1, OAK-D-PRO Depthai library version: 2.20.0

Visuals from testing

Add screenshots/gifs/videos from RVIZ or other visualizers demonstrating the effect of the changes when applicable.