search

luxonis / depthai-ros

Official ROS Driver for DepthAI Sensors.
MIT License
239 stars 173 forks source link

[BUG] [Humble] Missing dependency causes failure on the buildfarm #402

Closed audrow closed 9 months ago

audrow commented 10 months ago

The last release on Humble was missing a dependency for tf2_geometry_msgs in geometry2. https://build.ros2.org/view/Hbin_uJ64/job/Hbin_uJ64__depthai_bridge__ubuntu_jammy_amd64__binary/62/

A colleague also pointed out it'd be good add a dependency on tf2, even though it will be implicitly included in tf2_ros.

Serafadam commented 9 months ago

Hi, thanks for letting me know, it will be fixed soon, not sure why the CI showed green on this one before merging.

sloretz commented 9 months ago

Same issue on Noetic:

23:11:12 [ 75%] Building CXX object CMakeFiles/depthai_bridge.dir/src/TFPublisher.cpp.o
23:11:21 /usr/lib/ccache/c++  -DDEPTHAI_TARGET_CORE -DJSON_USE_IMPLICIT_CONVERSIONS=1 -DROSCONSOLE_BACKEND_LOG4CXX -DROS_BUILD_SHARED_LIBS=1 -DROS_PACKAGE_NAME=\"depthai_bridge\" -DUSING_ROS -Ddepthai_bridge_EXPORTS -I/tmp/binarydeb/ros-noetic-depthai-bridge-2.8.0/include -I/opt/ros/noetic/share/xmlrpcpp/cmake/../../../include/xmlrpcpp -I/usr/include/eigen3 -isystem /opt/ros/noetic/include -isystem /usr/include/opencv4 -isystem /opt/ros/noetic/include/depthai-shared/3rdparty -isystem /opt/ros/noetic/lib/arm-linux-gnueabihf/cmake/depthai/dependencies/include  -g -O2 -fdebug-prefix-map=/tmp/binarydeb/ros-noetic-depthai-bridge-2.8.0=. -fstack-protector-strong -Wformat -Werror=format-security -DNDEBUG -Wdate-time -D_FORTIFY_SOURCE=2 -fPIC   -std=gnu++14 -o CMakeFiles/depthai_bridge.dir/src/TFPublisher.cpp.o -c /tmp/binarydeb/ros-noetic-depthai-bridge-2.8.0/src/TFPublisher.cpp
23:11:21 /tmp/binarydeb/ros-noetic-depthai-bridge-2.8.0/src/TFPublisher.cpp:21:10: fatal error: tf2_geometry_msgs/tf2_geometry_msgs.h: No such file or directory
23:11:24    21 | #include "tf2_geometry_msgs/tf2_geometry_msgs.h"
sloretz commented 9 months ago

Looks like the most recent commit might fix it?

Serafadam commented 9 months ago

Fixes available in: https://github.com/ros/rosdistro/pull/38533#event-10360508632 https://github.com/ros/rosdistro/pull/38535#issuecomment-1717749952