Closed TSC21 closed 7 months ago
@saching13 @Serafadam would appreciate your review here. Thanks!
Thanks for the PR @TSC21. The CI had some problems in the past with this header so this was a temporary solution, but it seems that it has been fixed upstream :slightly_smiling_face:
Overview
This commit corrects an erroneous include path in the TFPublisher.cpp file. The original code incorrectly repeated the 'tf2_geometry_msgs' segment in the include directive, leading to a compilation error. The updated include statement correctly references 'tf2_geometry_msgs/tf2_geometry_msgs.hpp' without repetition.
This change ensures that the depthai_bridge package compiles successfully in ROS2 Humble by resolving the missing header file issue and aligns with standard ROS practices for including external dependencies.
Author: Nuno Marques (@TSC21).
Issue
depthai_bridge/src/TFPublisher.cpp
Changes
ROS distro: ROS 2 Humble List of changes:
depthai_bridge/src/TFPublisher.cpp
- change can be found on the diff.Testing
Hardware used: OAK-D W Depthai library version: the one which the Humble version of this package imports.
Visuals from testing
N.A. This can be validated by buiding the package from source against an environment built from source (In this case, with the srcs generated using
rosinstall_generator
and usingvcs import
). Fixing this include allowed to builddepthai_bridge
from source.