Fixes for #3 and #4 (dynamic user and library)

m-lab / murakami-viz

A visualization service of Murakami tests using Koa and React.

Apache License 2.0

1 stars 1 forks source link

Fixes for #3 and #4 (dynamic user and library) #11

Closed rudietuesdays closed 4 years ago

rudietuesdays commented 4 years ago

Update homepage interface to dynamically update user data for logged in user
Make library information dynamic based on library

jheretic commented 4 years ago

Okay, I went a little overboard with fixes on this branch, but this now looks good to me. I refactored things a bit in order to properly load the current user's library to populate the dashboard pages. The prop drilling could probably be refactored a bit in order to only do one fetch call against the library API endpoint instead of two, but that can be done later. Take a look and see if my changes look good to you @rudietuesdays !

rudietuesdays commented 4 years ago

All looks good to me @jheretic , thanks for the updates! Agreed on the fetch and opening a new issue for refactoring that.