m-lab / murakami-viz

A visualization service of Murakami tests using Koa and React.
Apache License 2.0
1 stars 1 forks source link

Change "View" to "Group by" on chart #24

Closed kelseysmithdesign closed 4 years ago

kelseysmithdesign commented 4 years ago

Users are not realizing that the “By Hour”, “By Day”, “By Month” are different ways to group the data. "By Hour, By Day, By Month" is understood as zoom-in buttons, not as aggregations/different views. Suggestion: Change the language to be “Group By ____”

But also, could this to moved to sidebar date picker?

rudietuesdays commented 4 years ago

@smithkelseyj pushed the update for the "Group by langauge" but I'm not sure I follow for where it should get moved. Should the entire line be moved under/next to the date ranger picker?

kelseysmithdesign commented 4 years ago

I don't know if that's been decided yet. We can discuss tomorrow. Sorry for the confusion!