search

m-lab / murakami-viz

A visualization service of Murakami tests using Koa and React.
Apache License 2.0
1 stars 1 forks source link

DNS server needs to support multiple IP addresses #76

Closed critzo closed 4 years ago

critzo commented 4 years ago

In both the "add a network" and "add a device" forms, the DNS server field needs to support multiple IP addresses.

rudietuesdays commented 4 years ago

@critzo is there a limited number of IPs that would need to be added to the DNS, or should it be unlimited?

Also, verifying that these are the fields that need the ability for multiple IPs:

Screen Shot 2020-09-18 at 11 53 13 AM Screen Shot 2020-09-18 at 11 53 24 AM
critzo commented 4 years ago

Hi @rudietuesdays. In the first field that is circled, there should be no limit to the number of IP addresses. It could be one field with comma or space separated IPs. This section is for "network settings", and I think there's another issue to allow multiple networks to be defined.

The second field you've circled is for the individual device's static IP (if it is not DHCP assigned). This field will contain one IP address. The field will be left blank if the IP is assigned by DHCP for that device. The field above it that is not circled but is labelled "DNS server" could be auto-populated with the values from the network this device is in, if we add a select item under New Device that first selects a network that had previously been added.

jheretic commented 4 years ago

@critzo quick dumb question, all of these address values are for the networks that are internal to the library, not external, right?

critzo commented 4 years ago

@jheretic not a dumb question. Static IPs for devices will all be internal IPs. DNS servers could be either internal IPs or external. For example, some libraries use OpenDNS, others use locally provisioned DNS servers, and some use both.