Closed HarryMakes closed 4 years ago
LGTM. Just one detail: the files should say "sgmii" instead of "1000basex". We can do that as a separate PR though, which would also update the targets.
Update: 10Mbps has also been tested on a Kasli.
Good. Please send another PR that does the renaming.
@sbourdeauducq Instead of choosing between sgmii
and 1000basex
, we might also consider gigabit
to indicate that the PCS implements 2 standards both derived from IEEE 802.3z Gigabit Ethernet. Not sure if this would be confusing in the 10/100Mbps context, however.
This pull request enables the existing 1000BASE-X PHY implementation to also support 10Mbps and 100Mbps via SGMII. This means the PHY can now automatically detect and operate in any of the following modes (tested on real testbench):
For further explanation on the implementation, see the full commit message for c0cf664404b7abdbdb1a38e56bae34abdfdee50e.