search

m-labs / misoc

The original high performance and small footprint system-on-chip based on Migen™
https://m-labs.hk
Other
305 stars 85 forks source link

Use asyncio in flterm instead of threads #12

Closed sbourdeauducq closed 8 years ago

sbourdeauducq commented 9 years ago

If removing the C version, clean up the python version (e.g. no threads).

enjoy-digital commented 9 years ago

OK, I'll look at that, you suggest asyncio to remove threads?

sbourdeauducq commented 9 years ago

Yes, though asyncio won't work easily with pyserial yet.

sbourdeauducq commented 8 years ago

Done in new branch. We are keeping only the Python version, when asyncserial works we should get rid of the threads.

sbourdeauducq commented 8 years ago

asyncio flterm is in separate branch. Works on Linux, needs testing on Windows.

enjoy-digital commented 8 years ago

Just tested flterm on windows, it seems to freeze here:

https://github.com/m-labs/misoc/blob/asyncserial/misoc/tools/flterm.py#L201 https://github.com/m-labs/pyserial/blob/master/serial/aio.py#L121 https://github.com/python/asyncio/blob/master/asyncio/windows_events.py#L425 https://github.com/python/asyncio/blob/master/asyncio/windows_events.py#L605

sbourdeauducq commented 8 years ago

Works now.