m-labs / misoc

The original high performance and small footprint system-on-chip based on Migen™
https://m-labs.hk
Other
306 stars 85 forks source link

merge a7ddrphy and k7ddrphy #57

Open sbourdeauducq opened 6 years ago

sbourdeauducq commented 6 years ago

@enjoy-digital why was that code duplicated?

enjoy-digital commented 6 years ago

Artix7 don't have ODELAYE2, but yes we could probably try to avoid duplicating common code.

sbourdeauducq commented 6 years ago

I don't understand how this can work without output delays. Is it by chance or...?

jordens commented 6 years ago

Look at the clocks.

jordens commented 6 years ago

Also BIOS fails compilation due to missing delay adjustment CSRs. Either the BIOS needs fixing to work with the phase shifted DQS or the merged PHY needs to handle it.

sbourdeauducq commented 5 years ago

https://github.com/m-labs/artiq/issues/1149#issuecomment-438773094