m-wrzr / streamlit-searchbox

Streamlit searchbox that dynamically updates and provides a list of suggestions based on a provided function
MIT License
253 stars 33 forks source link

Enhance Searchbox Component for Streamlit 1.37.0 Compatibility and Fragment Support (Issue #54) #55

Closed salmanrazzaq-94 closed 3 months ago

salmanrazzaq-94 commented 3 months ago

Linked to Issue #54

salmanrazzaq-94 commented 3 months ago

Thank you for your code review and detailed feedback. I've incorporated the suggested changes and am currently running the version from my fork. I noticed your update on streamlit/streamlit#9002 about the fix for the focus reset issue.

I believe that the fragmented rerun scope is a valuable feature and should be considered for future updates. I'll keep an eye on the implementation and ensure everything aligns with the latest fixes.

m-wrzr commented 3 months ago

Yeah, fragmented reruns definitely make sense and should be supported in the future! Hope this can be incorporated soon, I also don't like completely blocking streamlit version 1.37 like now..

Thanks again for the PR and bringing it up 👍 I'll keep an eye on it hopefully the reset issue get's fixed soon