search

m1k1o / neko-rooms

Selfhosted collaborative browser - room management for n.eko
Apache License 2.0
437 stars 59 forks source link

Bind Mount 'Template' changes to 'Private' after Room creation #128

Closed jameskitt616 closed 3 months ago

jameskitt616 commented 3 months ago

I couldn't figure out when exactly this happens, but it happens to me most of the time. Whenever i create a new room and create Mount of type 'Template' i fails most of the time. After submitting the form, the type for all the mounts changed to 'Private' instead of 'Template'.

m1k1o commented 3 months ago

That should be identified according to the path prefixes: https://github.com/m1k1o/neko-rooms/blob/76c0d28c28c47bfb15353f8580c7aa4dea27601f/internal/room/manager.go#L764-L769

When you inspect the docker container, do you see correct paths? Want to see if thats issue upon sending the form or just wrong visualization in GUI.

jameskitt616 commented 3 months ago

Upon creation i selected type 'Template' image

After creating when inspecting the Room it clearly shows 'Private' for both mounts image

When trying to start, it fails. image

m1k1o commented 3 months ago

It was only GUI issue. Should be fixed with the latest commit. Can you confirm?

jameskitt616 commented 3 months ago

I run neko-rooms via docker. So i need to wait for a new image on Dockerhub

jameskitt616 commented 3 months ago

Also thank you for the insane fast fix.

jameskitt616 commented 3 months ago

Yes, that fixed it. Thanks, you're awesome! <3