search

m2lines / EquationDisco

M²LInES equation discovery package.
MIT License
0 stars 1 forks source link

:notebook: Add README and example without pyqg #15

Open asross opened 1 year ago

asross commented 1 year ago

Addresses https://github.com/m2lines/EquationDisco/issues/10, https://github.com/m2lines/EquationDisco/issues/5, https://github.com/m2lines/EquationDisco/issues/9, and https://github.com/m2lines/EquationDisco/issues/6, superseding https://github.com/m2lines/EquationDisco/pull/11.

review-notebook-app[bot] commented 1 year ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

dorchard commented 1 year ago

Hi @asross - I found that just doing import eqn_disco wasn't working for me in the notebook because eqn_disco does not itself export the sub modules util etc. My solution is in this commit https://github.com/m2lines/EquationDisco/pull/15/commits/ef2fd0da618e4dbf1f22521883eff79aba4ca8db that way you can just do import eqn_disco as in your notebooks and get access to eqn_disco.util... etc. is that okay?

dorchard commented 7 months ago

@asross bump on the above - does my addition work okay for you?

asross commented 5 months ago

@dorchard Apologies for the late reply, just seeing this for some reason! Your change works for me 👍

dorchard commented 5 months ago

Okay that's great! There are a few other comments from me above. Can you take a look then I can approve.

asross commented 5 months ago

@dorchard not seeing the comments you mentioned above -- can you point me to them?