m2lines / EquationDisco

M²LInES equation discovery package.
MIT License
0 stars 1 forks source link

Code quality #8

Closed jdenholm closed 1 year ago

jdenholm commented 1 year ago

This pull request serves to address the items mentioned in issue #4 .

jdenholm commented 1 year ago

Hi @asross, do you think you could take a look at utils.py and help me with the TODOs, docstrings and variable names, please? I'd like the file to pass all of the checks I have mentioned in the first comment in this PR (where the check boxes are).

Hopefully everything is clear, but by all means give me a shout if not!

Cheers!

review-notebook-app[bot] commented 1 year ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

jdenholm commented 1 year ago

Also, hybrid_symbolic.py is ready for looking at, too! Give me a shout if you've any issues :)

asross commented 1 year ago

@jdenholm apologies for the delay, things have been crazy, but getting to this now!

jdenholm commented 1 year ago

@asross, no worries at all! 'Tis good to hear from you. There is no rush.