search

maarten-pennings / CCS811

Arduino library for the CCS811 gas sensor for monitoring indoor air quality.
MIT License
165 stars 46 forks source link

version checking functions have wrong comment, I think #67

Closed Habbie closed 2 years ago

Habbie commented 2 years ago

https://github.com/maarten-pennings/CCS811/blob/e9bba3611c3d9544732c45d0951f26c4d79898db/src/ccs811.cpp#L260 says returns 0 on I2C failure but reading the code I get the impression failure yields -1.

I did not run the code - I was just reading it for inspiration, so it's possible I missed something.

If it's true, it also appears to apply to the bootloader and appliication version calls.

maarten-pennings commented 2 years ago

You are right. Fixed them in v11.

Habbie commented 2 years ago

bedankt!