nox-review wip doesn't detect all failures - Githubissues

madjar / nox

Tools to make nix nicer to use

MIT License

305 stars 35 forks source link

nox-review wip doesn't detect all failures #52

Open abbradar opened 7 years ago

abbradar commented 7 years ago

I'm not sure what exactly is missing, but on this commit: https://github.com/NixOS/nixpkgs/commit/f8ea2347208cfeb4c88ca6319dc307bf16b47ae1 Travis failed but nox-review wip finished okay. Fixes for travis: https://github.com/NixOS/nixpkgs/commit/5d3cf921caecf67ebf93c3a155605c234421ec67, https://github.com/NixOS/nixpkgs/commit/23ff3dddba59b36be2f0dc0b318518a91674e967, more pending...

dezgeg commented 7 years ago

Travis additionally does the nixpkgs evaluation checks with nix-build pkgs/top-level/release.nix -A tarball and also builds of the manuals.