search

madjar / nox

Tools to make nix nicer to use
MIT License
305 stars 35 forks source link

nox-review: also offer option to rebuild changed tests #89

Closed symphorien closed 5 years ago

symphorien commented 5 years ago

The goal was to improve discoverability of tests. Related https://github.com/NixOS/nixpkgs/pull/44439 The result is not so good. It takes more than 10 minutes to evaluate all the tests, and we have to do it twice... Also installer tests need a copy of nixpkgs as a dependency so everytime something is changed in nixpkgs they need to be rebuilt. We need to blacklist them otherwise it will make nox-review --with-tests really unusable, but I haven't found any better solution than blacklisting by name...

symphorien commented 5 years ago

Hum by grouping evaluations in batches I can get down to 15 minutes for a nox-review (2 listings of tests and packages). This adds a new dependency: psutil, to evaluate how much parallelism is acceptable given the amount of free memory. Please test on a very recent master, tests in older nixpkgs don't evaluate enough for this to work: https://github.com/NixOS/nixpkgs/pull/44870 (and this even though I use tryEval...)

madjar commented 5 years ago

Nice work, thanks!