magento / magento2-phpstorm-plugin

PHPStorm Plugin for Magento 2
Open Software License 3.0
436 stars 102 forks source link

UCT live inspection only includes PHP and XML files #1101

Open svera opened 2 years ago

svera commented 2 years ago

Describe the bug (*) The built-in UCT only checks PHP and XML files in live inspection. For example, checking magepal/magento2-core version 1.1.12, bundle UCT returns a bunch of deprecated warnings for escapeHtml() in view/adminhtml/templates/system/config/field/extensions.phtml which are not reflected in live inspection.

To Reproduce (*)

Steps to reproduce the behaviour:

  1. Install magepal/magento2-googletagmanager 2.7.1 in a Magento instance using composer (magepal/magento2-core is installed also as a requirement): composer require magepal/magento2-googletagmanager
  2. Analyse magepal/magento2-core from the vendorfolder using the built-in UCT
  3. After UCT finishes its analysis, open view/adminhtml/templates/system/config/field/extensions.phtml from the analysis results
  4. Live inspection of file above should highlight the errors found by UCT

Expected behaviour (*)

Issues in PHTML and other file extensions supported by UCT should be highlighted in live inspection.

Screenshots

Screenshot 2022-05-16 at 11 47 55

Please complete the following information: (*)

m2-assistant[bot] commented 2 years ago

Hi @svera. Thank you for your report. To speed up processing of this issue, make sure that you provided sufficient information.

Add a comment to assign the issue: @magento I am working on this


bohdan-harniuk commented 2 years ago

Hello, @svera!

This is not a bug. You should configure path to analyse for the live inspection to work with. Please, provide your configuration.

Regards,

svera commented 2 years ago

Hi @bohdan-harniuk , path is already provided, see next screenshot:

Screenshot 2022-05-17 at 11 15 48

also, live inspection is working fine in PHP files, as you can see in the attached image:

Screenshot 2022-05-17 at 11 20 37
bohdan-harniuk commented 2 years ago

@svera, *.phtml files are working fine for app/code and app/design directories. It seems, that the problem appears with the 3rd party modules in the vendor directory. I'll check this issue.

Thank you, for your report!