search

magento / magento2-phpstorm-plugin

PHPStorm Plugin for Magento 2
Open Software License 3.0
435 stars 102 forks source link

How to fix "Thread context was already set" #2080

Open piotrkwiecinski opened 3 months ago

piotrkwiecinski commented 3 months ago

To properly fix this issue JDialog extend in https://github.com/magento/magento2-phpstorm-plugin/blob/5.3.0-develop/src/com/magento/idea/magento2plugin/actions/generation/dialog/AbstractDialog.java#L38 has to be replaced by DialogWrapper: https://plugins.jetbrains.com/docs/intellij/dialog-wrapper.html?from=jetbrains.org#examples

Based on the answer from the official support: https://intellij-support.jetbrains.com/hc/en-us/community/posts/14397678486418--Thread-context-was-already-set-CoroutineName-commit-workflow-when-showing-window-during-commit-check?page=1#community_comment_15082225353874

Here is an implementation from other plugin: https://github.com/jshiell/checkstyle-idea/commit/810239607bd11590a27c8931c236360e37805a34

This is going to close ~60 bug reports.

m2-assistant[bot] commented 3 months ago

Hi @piotrkwiecinski. Thank you for your report. To speed up processing of this issue, make sure that you provided sufficient information. Add a comment to assign the issue: @magento I am working on this

Join Magento Community Engineering Slack and ask your questions in #github channel.

piotrkwiecinski commented 3 months ago

@magento I am working on this

piotrkwiecinski commented 2 months ago

@VitaliyBoyko could we leave this one open?