magento / magento2

Prior to making any Submission(s), you must sign an Adobe Contributor License Agreement, available here at: https://opensource.adobe.com/cla.html. All Submissions you make to Adobe Inc. and its affiliates, assigns and subsidiaries (collectively “Adobe”) are subject to the terms of the Adobe Contributor License Agreement.
http://www.magento.com
Open Software License 3.0
11.47k stars 9.29k forks source link

Currency issue in Product details and Shopping cart page for base currency other than USD / EURO #34003

Open onlinebizsoft opened 3 years ago

onlinebizsoft commented 3 years ago
  1. Use base currency as GBP for example
  2. Use Display currency as USD or MAD for example (store currency and base currency must be very different to see the issue)
  3. Setup a few custom options (customizable options) with additional prices (do not test with configurable product) 

    Steps to reproduce

  4. Use base currency as GBP(Stores-Configuration-General-Currency Setup).
  5. Use Display currency as USD.
  6. Save the config and clear cache
  7. View the Product on front end
  8. View Shopping Cart page

Expected result (*)

The Currency should be displayed with USD for a product as per Configuration

Note:

If we use Base currency as EUR and Display currency as USD we have a option for changing currency on the right corner in frontend.

Actual result (*)

There is a difference in Currency symbol for a Product. It is displayed with currency GBP(British Pound).

If we use Base currency as GBP and Display currency as USD or MAD we miss that option for changing currency on the right corner in frontend. Tested with other Currency Configurations.

Please provide Severity assessment for the Issue as Reporter. This information will help during Confirmation and Issue triage processes.

m2-assistant[bot] commented 3 years ago

Hi @onlinebizsoft. Thank you for your report. To help us process this issue please make sure that you provided the following information:

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, please, review the Magento Contributor Assistant documentation.

Please, add a comment to assign the issue: @magento I am working on this


:clock10: You can find the schedule on the Magento Community Calendar page.

:telephone_receiver: The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

:movie_camera: You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

:pencil2: Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

onlinebizsoft commented 3 years ago

I think there are different problem in different user cases, I can see there were some question or patch from the community for different cases https://github.com/magesuite/magento-patches/blob/master/optional/m24-fix-different-price-in-cart-vs-on-pdp.patch https://community.magento.com/t5/Magento-1-x-Programming/Custom-Option-Price-calculated-wrong/td-p/7033

onlinebizsoft commented 3 years ago

@engcom-Hotel

m2-assistant[bot] commented 3 years ago

Hi @engcom-Delta. Thank you for working on this issue. In order to make sure that issue has enough information and ready for development, please read and check the following instruction: :point_down:

engcom-Delta commented 3 years ago

Hi @onlinebizsoft , I tried in reproducing the issue on Magento 2.4 Develop. i could see that price of the product is same in Product view page & cart ,price is same everywhere. Kindly find the attached screenshots for reference. Product_page Euro_dollar US_Dollar

It would be great if you can provide what are the base price you had customized so that we can replicate it. Hence added 'Needs Update' label.

onlinebizsoft commented 3 years ago

@engcom-Delta what additional price are you testing for custom option "L" and "Yellow" ? Is it customizable option or configurable product?

onlinebizsoft commented 3 years ago

@engcom-Delta I believe that you didn't look at "pre-conditions" at all, I wrote clearly that you need to test with customizable options and make sure that these customizable options have additional prices.

You could imagine the case you sell custom made product (phone cases for example), you don't have any item in stock, your products has options like made by leather, gold, may add some diamond stones,....etc so these products setup would be using custom options and having additional prices.

onlinebizsoft commented 2 years ago

The issue is very clear and it is quite bad, I think not many people are using customizable option with additional price so no one raised it. Can you please confirm the issue again @engcom-Delta @engcom-November ?

ihor-sviziev commented 2 years ago

@onlinebizsoft, the options in the custom options are saying +$N, and it's not changing the final price on the product page when you're selecting an option, so it's basically ok behavior (not the best one, but not so terrible).

onlinebizsoft commented 2 years ago

@ihor-sviziev I agree with the way it calcuate the price on the preview product view but you see we cant have different price between 2 places. Customer see 1 price then they add to cart and see another price! So the most possible solution might be having the price calcuated in the same way on cart? So we convert currency for base price, custom option price,....first.

engcom-Delta commented 2 years ago

Hi @onlinebizsoft, We could find out that issue with Euro currency only but it works fine for Dollar Currency . Hence added the label 'Issue Confirmed'. Please find the attached screen shots for reference. Dollor_currency_NODifference Euro_currency_Difference

github-jira-sync-bot commented 2 years ago

:white_check_mark: Jira issue https://jira.corp.magento.com/browse/AC-1558 is successfully created for this GitHub issue.

m2-assistant[bot] commented 2 years ago

:white_check_mark: Confirmed by @engcom-Delta. Thank you for verifying the issue.
Issue Available: @engcom-Delta, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

engcom-Alfa commented 2 years ago

The issue is existing for EUR currency type as mentioned in description. It will be good if are going to notice in with any other currencies as well. Accordingly the procedure to fix the issue may change!

onlinebizsoft commented 2 years ago

@engcom-Alfa it happens with ANY currency which is different from the base currency

ihor-sviziev commented 2 years ago

@sidolov @sivaschenko why this issue was closed without any comment?

onlinebizsoft commented 2 years ago

@ihor-sviziev @engcom-Alfa any news? strange behavior of closing issue!

onlinebizsoft commented 2 years ago

@ihor-sviziev @engcom-Alfa there is no one looking at such thing??

onlinebizsoft commented 2 years ago

There is also no rule for people to complain about such behavior :|

ihor-sviziev commented 2 years ago

@sidolov any comments?

sdzhepa commented 2 years ago

@ihor-sviziev @onlinebizsoft

Sorry for such incident. I will ask "engcom-xxx" squad to investigate and provide updates here ASAP

cc: @sidolov

engcom-Hotel commented 2 years ago

Hello @onlinebizsoft,

We are reopening the issue for further investigation.

Thanks

m2-assistant[bot] commented 2 years ago

Hi @engcom-November. Thank you for working on this issue. In order to make sure that issue has enough information and ready for development, please read and check the following instruction: :point_down:

engcom-Hotel commented 2 years ago

Hello @onlinebizsoft,

We have rechecked the issue on the latest development branch i.e. Magento 2.4-develop. The issue is reproducible. The team has started working on it.

Thanks

engcom-Bravo commented 2 years ago

@magento give me 2.4-develop instance

magento-deployment-service[bot] commented 2 years ago

Hi @engcom-Bravo. Thank you for your request. I'm working on Magento instance for you.

m2-assistant[bot] commented 2 years ago

Hi @engcom-Bravo. Thank you for working on this issue. In order to make sure that issue has enough information and ready for development, please read and check the following instruction: :point_down:

magento-deployment-service[bot] commented 2 years ago

Hi @engcom-Bravo, here is your Magento Instance: https://acbafd3ea106f7554cf7c1f20ae683d5.instances.magento-community.engineering Admin access: https://acbafd3ea106f7554cf7c1f20ae683d5.instances.magento-community.engineering/admin_5c48 Login: bb3759ef Password: 72ce8b068c3b

engcom-Bravo commented 2 years ago

Hi @onlinebizsoft,

Thank you for reporting and collaboration. Verified the issue on Magento 2.4-develop branch but could not able to reproduce the issue.

Kindly refer the screenshots.

vk vk 1

We are able to see the prices same everywhere.

Let us know we miss anything.

Thanks.

onlinebizsoft commented 2 years ago

@engcom-Bravo yes you are missing very important information.

  1. You didn't tell me which base currency and store currency are you using?
  2. You know USD is almost same as EUR now so you can't see the issue if you are testing with these 2 currencies.
  3. The issue were confirmed previously https://github.com/magento/magento2/issues/34003#issuecomment-952702795
engcom-Bravo commented 2 years ago

@magento give me 2.4-develop instance

magento-deployment-service[bot] commented 2 years ago

Hi @engcom-Bravo. Thank you for your request. I'm working on Magento instance for you.

magento-deployment-service[bot] commented 2 years ago

Hi @engcom-Bravo, here is your Magento Instance: https://acbafd3ea106f7554cf7c1f20ae683d5.instances.magento-community.engineering Admin access: https://acbafd3ea106f7554cf7c1f20ae683d5.instances.magento-community.engineering/admin_86db Login: 341988b2 Password: a650809d4ee5

engcom-Bravo commented 2 years ago

Hi @onlinebizsoft,

Thanks for quick response.

As per above comment we used British Pound as Base currency and Store Currency.

100

Verified the issue on Magento 2.4-develop branch but could not able to reproduce the issue.

101 102

Let us know we miss anything.

Thanks.

onlinebizsoft commented 2 years ago

@engcom-Bravo You just need to check the ticket description where I mentioned very clearly about the condition image

So you are setting GPB for both base currency and store currency which is wrong, you need to use 2 different currencies for these setting.

engcom-Bravo commented 2 years ago

@magento give me 2.4-develop instance

magento-deployment-service[bot] commented 2 years ago

Hi @engcom-Bravo. Thank you for your request. I'm working on Magento instance for you.

magento-deployment-service[bot] commented 2 years ago

Hi @engcom-Bravo, here is your Magento Instance: https://acbafd3ea106f7554cf7c1f20ae683d5.instances.magento-community.engineering Admin access: https://acbafd3ea106f7554cf7c1f20ae683d5.instances.magento-community.engineering/admin_3cf3 Login: f56310f6 Password: 15118a70ab12

engcom-Bravo commented 2 years ago

Hi @onlinebizsoft,

Thanks for quick response.

Thank you for reporting and collaboration. Verified the issue on Magento 2.4-develop branch but could not able to reproduce the issue. Kindly refer the screenshots.

1.Setting up the Base currency and Store Currency is different.

kd

2.We are not able to see any price difference between product view and shopping cart.

kd1 kd2

As per your steps to reproduce we are taking some examples and setting up different base currency and store currency.

kd3 kd4 kd5 kd6 kd7 kd8

Please Let us know we miss anything.

Thanks.

onlinebizsoft commented 2 years ago

@engcom-Bravo The second example is good for testing (British Pound and Jamaican Dollar). From your screenshots, in admin setting, I see you set display currency as Jamaican Dollar but how can you show British Pound on frontend ?

engcom-Bravo commented 2 years ago

@magento give me 2.4-develop instance

magento-deployment-service[bot] commented 2 years ago

Hi @engcom-Bravo. Thank you for your request. I'm working on Magento instance for you.

magento-deployment-service[bot] commented 2 years ago

Hi @engcom-Bravo, here is your Magento Instance: https://acbafd3ea106f7554cf7c1f20ae683d5.instances.magento-community.engineering Admin access: https://acbafd3ea106f7554cf7c1f20ae683d5.instances.magento-community.engineering/admin_4805 Login: cb5d6d46 Password: 455f6de7010b

engcom-Bravo commented 2 years ago

HI @onlinebizsoft,

Thank you for reporting and collaboration.

Verified the issue on Magento 2.4-develop branch we are able to reproduce the issue. Kindly refer the screenshots.

1.Setting up a base currency as GBP and store currency as USD.

t1

2.As we are setting up a store currency as USD. We are not able to see the USD Price, the price is in GBP in Store View.

t2

3.Setting up a base currency as GBP and store currency as MAD.

t4

4.As we are setting up a store currency as MAD. We are not able to see the MAD Price, the price is in GBP in Store View.

t5

We are getting a different currency symbol apart from a configuration in store view for a product.

Hence Confirming the issue.

Thanks.

engcom-November commented 2 years ago

@magento give me 2.4-develop instance

magento-deployment-service[bot] commented 2 years ago

Hi @engcom-November. Thank you for your request. I'm working on Magento instance for you.

magento-deployment-service[bot] commented 2 years ago

Hi @engcom-November, here is your Magento Instance: https://acbafd3ea106f7554cf7c1f20ae683d5.instances.magento-community.engineering Admin access: https://acbafd3ea106f7554cf7c1f20ae683d5.instances.magento-community.engineering/admin_7ed3 Login: a320f3d6 Password: bd6e2563bc23

github-jira-sync-bot commented 2 years ago

:x: Cannot export the issue. This GitHub issue is already linked to Jira issue(s): https://jira.corp.adobe.com/browse/AC-1558

onlinebizsoft commented 2 years ago

@ihor-sviziev @engcom-Bravo @engcom-November @engcom-Delta this is not the issue I have reported. If it is valid then it is another issue, my issue were confirmed but new QA seems doesn't understand the issue and we get nowhere now.

engcom-November commented 2 years ago

@magento give me 2.4-develop instance