Attempting to Place Order with payment method of G Pay (Google Pay) fails

n2diving-dgx commented 2 years ago

Preconditions and environment

Attempting to Place Order with payment method of G Pay (Google Pay) fails with error message...

"Request Failed Unexpected developer error, please try again later."

Environment is M2.4.4 with PHP 7.4 using native Braintree extension bundled with M2.4.4 Problem appears to have begun co-incident with upgrade from M2.4.3-p1 to M2.4.4

IMPORTANT: There is a "sandbox" vs "production" aspect to this problem. When M2.4.4 is in production mode using the Basic Braintree Settings of Environment = "Sandbox" a checkout with G Pay succeeds... switch the Braintree Environment to "Production", validate credentials and clear cache... checkout with G Pay fails as described. What this means is you will be unable to reproduce the problem without using live Production credentials with Braintree.

Steps to reproduce

Upgrade working M2.4.3-p1 environment with working G Pay payment method to M2.4.4 using "Production" Braintree credentials

IMPORTANT: There is a "sandbox" vs "production" aspect to this problem. When M2.4.4 is in production mode using the Basic Braintree Settings of Environment = "Sandbox" a checkout with G Pay succeeds... switch the Braintree Environment to "Production", validate credentials and clear cache... checkout with G Pay fails as described. What this means is you will be unable to reproduce the problem without using live Production credentials with Braintree.

Expected result

G Pay continues to work as an accepted payment method.

Actual result

Attempting to Place Order with payment method of G Pay (Google Pay) fails with error message...

Request Failed Unexpected developer error, please try again later.

There were no associated errors present in system.log

Additional information

Environment is M2.4.4 (Production) with PHP 7.4 using native Braintree extension bundled with M2.4.4 Problem appears to have begun co-incident with upgrade from M2.4.3-p1 to M2.4.4

Customer is unable to make payment via Gpay and must choose a different payment method. G Pay payments are relatively rare and this issue was only detected day after the upgrade M2.4.4 when a customer complained of being unable to make payment via G Pay.

IMPORTANT: There is a "sandbox" vs "production" aspect to this problem. When M2.4.4 is in production mode using the Basic Braintree Settings of Environment = "Sandbox" a checkout with G Pay succeeds... switch the Braintree Environment to "Production", validate credentials and clear cache... checkout with G Pay fails as described. What this means is you will be unable to reproduce the problem without using live Production credentials with Braintree.

Release note

No response

Triage and priority

[ ] Severity: S0 - Affects critical data or functionality and leaves users without workaround.
[X] Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
[ ] Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
[ ] Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
[ ] Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.

m2-assistant[bot] commented 2 years ago

Hi @n2diving-dgx. Thank you for your report. To speed up processing of this issue, make sure that you provided the following information:

Summary of the issue
Information on your environment
Steps to reproduce
Expected and actual results

Make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, Add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, review the Magento Contributor Assistant documentation.

Add a comment to assign the issue: @magento I am working on this

To learn more about issue processing workflow, refer to the Code Contributions.

Join Magento Community Engineering Slack and ask your questions in #github channel.

:warning: According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

:clock10: You can find the schedule on the Magento Community Calendar page.

:telephone_receiver: The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

:pencil2: Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

n2diving-dgx commented 2 years ago

Fails on both Android/Chrome (S22 phone) and Win11/Chrome desktop...

m2-assistant[bot] commented 2 years ago

Hi @engcom-Delta. Thank you for working on this issue. In order to make sure that issue has enough information and ready for development, please read and check the following instruction: :point_down:

[ ] 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
Details
If the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.
[ ] 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.
[ ] 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.
[ ] 4. Verify that the issue is reproducible on 2.4-develop branch
Details
- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
- If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
- If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
[ ] 5. Add label Issue: Confirmed once verification is complete.
[ ] 6. Make sure that automatic system confirms that report has been added to the backlog.

cankarales commented 2 years ago

I have a simmilar issue so here are my 2 cents.

I found that there is an issue in this file: Paypal_Braintree/js/googlepay.js on lines 133 through 135:

if (this.getEnvironment() !== "TEST") {
    result['merchantId'] = this.getMerchantId();
}

the if() statement implies that this issue only appears in production environments. If you remove it, you'll get the same error which is:

DEVELOPER_ERROR in loadPaymentData: PaymentDataRequest.merchantId does not exist.

this means that merchantId is not a valid field, which according to Google Pay docs is true. Correct way would be like this:

if (this.getEnvironment() !== "TEST") {
    result.merchantInfo = { merchantId: this.getMerchantId() };
}

This was I'm allowed to enter my card info but then I get a different error...

engcom-Delta commented 2 years ago

@magento give me 2.4.4 instance

magento-deployment-service[bot] commented 2 years ago

Hi @engcom-Delta. Thank you for your request. I'm working on Magento instance for you.

magento-deployment-service[bot] commented 2 years ago

Hi @engcom-Delta, unfortunately there is no ability to deploy Magento instance at the moment. Please try again later.

engcom-Delta commented 2 years ago

@magento give me 2.4-develop instance

magento-deployment-service[bot] commented 2 years ago

Hi @engcom-Delta. Thank you for your request. I'm working on Magento instance for you.

magento-deployment-service[bot] commented 2 years ago

Hi @engcom-Delta, here is your Magento Instance: https://b702508b9e5bce2579c237f7f5106e93.instances.magento-community.engineering Admin access: https://b702508b9e5bce2579c237f7f5106e93.instances.magento-community.engineering/admin_619f Login: 13299065 Password: fd847e4e9e96

engcom-Delta commented 2 years ago

@magento give me 2.4-develop instance

engcom-Delta commented 2 years ago

@magento give me 2.4-develop instance

magento-deployment-service[bot] commented 2 years ago

Hi @engcom-Delta. Thank you for your request. I'm working on Magento instance for you.

magento-deployment-service[bot] commented 2 years ago

Hi @engcom-Delta, here is your Magento Instance: https://b702508b9e5bce2579c237f7f5106e93.instances.magento-community.engineering Admin access: https://b702508b9e5bce2579c237f7f5106e93.instances.magento-community.engineering/admin_dd10 Login: aeda6144 Password: a4d63f178f5c

Kishorchhugani commented 2 years ago

I am Facing the Same issue While Using Gpay in my checkout in magento version 2.4.4

Kishorchhugani commented 2 years ago

hi @engcom-Delta any Updates?

engcom-Delta commented 2 years ago

@magento give me 2.4-develop instance

magento-deployment-service[bot] commented 2 years ago

Hi @engcom-Delta, unfortunately there is no ability to deploy Magento instance at the moment. Please try again later.

engcom-Delta commented 2 years ago

@magento give me 2.4-develop instance

magento-deployment-service[bot] commented 2 years ago

Hi @engcom-Delta, unfortunately there is no ability to deploy Magento instance at the moment. Please try again later.

engcom-Hotel commented 2 years ago

@magento give me 2.4-develop instance

magento-deployment-service[bot] commented 2 years ago

Hi @engcom-Hotel, unfortunately there is no ability to deploy Magento instance at the moment. Please try again later.

slavvka commented 2 years ago

https://github.com/magento give me 2.4-develop instance

slavvka commented 2 years ago

@magento give me 2.4-develop instance

magento-deployment-service[bot] commented 2 years ago

Hi @slavvka, unfortunately there is no ability to deploy Magento instance at the moment. Please try again later.

slavvka commented 2 years ago

@magento give me 2.4-develop instance

magento-deployment-service[bot] commented 2 years ago

Hi @slavvka, unfortunately there is no ability to deploy Magento instance at the moment. Please try again later.

slavvka commented 2 years ago

@magento give me 2.4-develop instance

magento-deployment-service[bot] commented 2 years ago

Hi @slavvka, unfortunately there is no ability to deploy Magento instance at the moment. Please try again later.

magento-deployment-service[bot] commented 2 years ago

Hi @slavvka, unfortunately there is no ability to deploy Magento instance at the moment. Please try again later.

magento-deployment-service[bot] commented 2 years ago

Hi @slavvka, unfortunately there is no ability to deploy Magento instance at the moment. Please try again later.

slavvka commented 2 years ago

@magento give me 2.4-develop instance

magento-deployment-service[bot] commented 2 years ago

Hi @slavvka. Thank you for your request. I'm working on Magento instance for you.

magento-deployment-service[bot] commented 2 years ago

Hi @slavvka, here is your Magento Instance: https://b702508b9e5bce2579c237f7f5106e93.instances.magento-community.engineering Admin access: https://b702508b9e5bce2579c237f7f5106e93.instances.magento-community.engineering/admin_a538 Login: 8107abd1 Password: 3327bcb11fe7

engcom-Delta commented 2 years ago

@magento give me 2.4-develop instance

magento-deployment-service[bot] commented 2 years ago

Hi @engcom-Delta. Thank you for your request. I'm working on Magento instance for you.

magento-deployment-service[bot] commented 2 years ago

Hi @engcom-Delta, here is your Magento Instance: https://b702508b9e5bce2579c237f7f5106e93.instances.magento-community.engineering Admin access: https://b702508b9e5bce2579c237f7f5106e93.instances.magento-community.engineering/admin_4fbb Login: 0d31542c Password: fcc3c90d6158

engcom-Hotel commented 2 years ago

@magento give me 2.4.4 instance

engcom-Hotel commented 2 years ago

@magento give me 2.4.4 instance

magento-deployment-service[bot] commented 2 years ago

Hi @engcom-Hotel. Thank you for your request. I'm working on Magento instance for you.

magento-deployment-service[bot] commented 2 years ago

Hi @engcom-Hotel, unfortunately there is no ability to deploy Magento instance at the moment. Please try again later.

engcom-Hotel commented 2 years ago

@magento give me 2.4.4 instance

magento-deployment-service[bot] commented 2 years ago

Hi @engcom-Hotel. Thank you for your request. I'm working on Magento instance for you.

magento-deployment-service[bot] commented 2 years ago

Hi @engcom-Hotel, unfortunately there is no ability to deploy Magento instance at the moment. Please try again later.

n2diving-dgx commented 2 years ago

FYI, I contacted the original authors of the Braintree extension embedded in 2.4.4, named Gene Commerce, and they were able to reproduce the problem using live credentials. They have developed a patch which resolves the issue.

The logic flaw in sandbox testing only is the payment extension contains a significant amount of conditional code that only executes in production mode, thus can get through the entire release process without being tested because testing only uses sandbox credentials which only work in sandbox mode.

cankarales commented 2 years ago

@n2diving-dgx correct! I already pointed this out in my first comment. Has Gene Commerce already released the patch? If so, where can we find it?

engcom-Hotel commented 2 years ago

@magento give me 2.4.4 instance

magento-deployment-service[bot] commented 2 years ago

Hi @engcom-Hotel. Thank you for your request. I'm working on Magento instance for you.

magento-deployment-service[bot] commented 2 years ago

Hi @engcom-Hotel, unfortunately there is no ability to deploy Magento instance at the moment. Please try again later.

engcom-Delta commented 2 years ago

@magento give me 2.4-develop instance with edition ee

magento / magento2