magento / magento2

Prior to making any Submission(s), you must sign an Adobe Contributor License Agreement, available here at: https://opensource.adobe.com/cla.html. All Submissions you make to Adobe Inc. and its affiliates, assigns and subsidiaries (collectively “Adobe”) are subject to the terms of the Adobe Contributor License Agreement.
http://www.magento.com
Open Software License 3.0
11.53k stars 9.31k forks source link

Attempting to Place Order with payment method of G Pay (Google Pay) fails #35584

Closed n2diving-dgx closed 2 years ago

n2diving-dgx commented 2 years ago

Preconditions and environment

Attempting to Place Order with payment method of G Pay (Google Pay) fails with error message...

"Request Failed Unexpected developer error, please try again later."

Environment is M2.4.4 with PHP 7.4 using native Braintree extension bundled with M2.4.4 Problem appears to have begun co-incident with upgrade from M2.4.3-p1 to M2.4.4

IMPORTANT: There is a "sandbox" vs "production" aspect to this problem. When M2.4.4 is in production mode using the Basic Braintree Settings of Environment = "Sandbox" a checkout with G Pay succeeds... switch the Braintree Environment to "Production", validate credentials and clear cache... checkout with G Pay fails as described. What this means is you will be unable to reproduce the problem without using live Production credentials with Braintree.

Steps to reproduce

Upgrade working M2.4.3-p1 environment with working G Pay payment method to M2.4.4 using "Production" Braintree credentials

IMPORTANT: There is a "sandbox" vs "production" aspect to this problem. When M2.4.4 is in production mode using the Basic Braintree Settings of Environment = "Sandbox" a checkout with G Pay succeeds... switch the Braintree Environment to "Production", validate credentials and clear cache... checkout with G Pay fails as described. What this means is you will be unable to reproduce the problem without using live Production credentials with Braintree.

Expected result

G Pay continues to work as an accepted payment method.

Actual result

Attempting to Place Order with payment method of G Pay (Google Pay) fails with error message...

Request Failed Unexpected developer error, please try again later.

There were no associated errors present in system.log

Additional information

Environment is M2.4.4 (Production) with PHP 7.4 using native Braintree extension bundled with M2.4.4 Problem appears to have begun co-incident with upgrade from M2.4.3-p1 to M2.4.4

Customer is unable to make payment via Gpay and must choose a different payment method. G Pay payments are relatively rare and this issue was only detected day after the upgrade M2.4.4 when a customer complained of being unable to make payment via G Pay.

IMPORTANT: There is a "sandbox" vs "production" aspect to this problem. When M2.4.4 is in production mode using the Basic Braintree Settings of Environment = "Sandbox" a checkout with G Pay succeeds... switch the Braintree Environment to "Production", validate credentials and clear cache... checkout with G Pay fails as described. What this means is you will be unable to reproduce the problem without using live Production credentials with Braintree.

Release note

No response

Triage and priority

magento-deployment-service[bot] commented 2 years ago

Hi @engcom-Delta. Thank you for your request. I'm working on Magento instance for you.

magento-deployment-service[bot] commented 2 years ago

Hi @engcom-Delta, here is your Magento Instance: https://b702508b9e5bce2579c237f7f5106e93.instances.magento-community.engineering Admin access: https://b702508b9e5bce2579c237f7f5106e93.instances.magento-community.engineering/admin_2b0c Login: 48b87e02 Password: 1643681aadf2

engcom-Delta commented 2 years ago

@magento give me 2.4.3-p1 instance with edition ee

magento-deployment-service[bot] commented 2 years ago

Hi @engcom-Delta. Thank you for your request. I'm working on Magento instance for you.

magento-deployment-service[bot] commented 2 years ago

Hi @engcom-Delta, unfortunately there is no ability to deploy Magento instance at the moment. Please try again later.

engcom-Delta commented 2 years ago

@magento give me 2.4.4 instance with edition ee

magento-deployment-service[bot] commented 2 years ago

Hi @engcom-Delta. Thank you for your request. I'm working on Magento instance for you.

magento-deployment-service[bot] commented 2 years ago

Hi @engcom-Delta, unfortunately there is no ability to deploy Magento instance at the moment. Please try again later.

engcom-Hotel commented 2 years ago

@magento give me 2.4.4 instance with edition ee

magento-deployment-service[bot] commented 2 years ago

Hi @engcom-Hotel. Thank you for your request. I'm working on Magento instance for you.

magento-deployment-service[bot] commented 2 years ago

Hi @engcom-Hotel, unfortunately there is no ability to deploy Magento instance at the moment. Please try again later.

engcom-Delta commented 2 years ago

@magento give me 2.4.4 instance

magento-deployment-service[bot] commented 2 years ago

Hi @engcom-Delta. Thank you for your request. I'm working on Magento instance for you.

magento-deployment-service[bot] commented 2 years ago

Hi @engcom-Delta, unfortunately there is no ability to deploy Magento instance at the moment. Please try again later.

engcom-Delta commented 2 years ago

@magento give me 2.4.4 instance with edition ee

magento-deployment-service[bot] commented 2 years ago

Hi @engcom-Delta. Thank you for your request. I'm working on Magento instance for you.

magento-deployment-service[bot] commented 2 years ago

Hi @engcom-Delta, unfortunately there is no ability to deploy Magento instance at the moment. Please try again later.

engcom-Delta commented 2 years ago

@magento give me 2.4.4 instance

magento-deployment-service[bot] commented 2 years ago

Hi @engcom-Delta. Thank you for your request. I'm working on Magento instance for you.

magento-deployment-service[bot] commented 2 years ago

Hi @engcom-Delta, unfortunately there is no ability to deploy Magento instance at the moment. Please try again later.

j-lloyd-slc commented 2 years ago

This continues to be an issue with Google Pay and 2.4.4. I have not been able to get a response from the developer.

m2-assistant[bot] commented 2 years ago

Hi @engcom-Hotel. Thank you for working on this issue. In order to make sure that issue has enough information and ready for development, please read and check the following instruction: :point_down:

engcom-Hotel commented 2 years ago

Hello @n2diving-dgx,

The Code of this extension is not part of the https://github.com/magento/magento2 git repository.

The community is not able to provide a fix in this repository, and we are not able to deliver such Pull Request

All questions, issue reports and fix for them should be addressed to the corresponding extension owners(support) on the Magento Marketplace page

Hence closing this issue from here.

Thanks

ecoprince commented 2 years ago

I found an issue with getPaymentRequest() structure.

Solution: vendor/paypal/module-braintree-core/view/frontend/web/js/googlepay/implementations/core-checkout/method-renderer/googlepay.js

getPaymentRequest()

 if (this.getEnvironment() !== "TEST") {
      result.merchantInfo = {
          "merchantId": this.getMerchantId()
      };
 }
johncarlson21 commented 1 year ago

the above fix works, however only on the checkout page and not for the buttons on the cart page or the mini cart. I'm not even sure how this gets loaded to my magento and I've been trying to find the actual package repo as there is an update for it according to composer, however it will not update until you either force it or I believe upgrade your version of magento. I would like to see the code for the paypal/braintree package so I can determine if it was actually fixed. any insight would be helpful.