magiblot / tvision

A modern port of Turbo Vision 2.0, the classical framework for text-based user interfaces. Now cross-platform and with Unicode support.
Other
1.99k stars 150 forks source link

Warning: enumerated and non-enumerated type in conditional expression in TStringView::operator== #154

Closed rayslava closed 6 months ago

rayslava commented 6 months ago

When compiling with g++ -Wextra there's a warning in TStringView::operator==:

tvision/include/tvision/tstrview.h: In function ‘constexpr Boolean operator==(TStringView, TStringView)’:
tvision/include/tvision/tstrview.h:208:7: warning: enumerated and non-enumerated type in conditional expression [-Wextra]
  207 |     return a.size() == b.size()
      |            ~~~~~~~~~~~~~~~~~~~~
  208 |       ? std::char_traits<char>::compare(a.data(), b.data(), b.size()) == 0
      |       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  209 |       : False;
      |       ~~~~~~~

Not a big deal, but still irritating

magiblot commented 6 months ago

Done. Thanks for reporting!