Fix alloc-dealloc mismatches reported by ASAN when running tvdir

magiblot / tvision

A modern port of Turbo Vision 2.0, the classical framework for text-based user interfaces. Now cross-platform and with Unicode support.

Other

1.99k stars 150 forks source link

Fix alloc-dealloc mismatches reported by ASAN when running tvdir #74

Closed Michael137 closed 2 years ago

Michael137 commented 2 years ago

While integrating tvdir into one of my applications ASAN found a couple of mismatched new/delete calls. There may be more around but I haven't run ASAN on everything yet.

Following are the ASAN logs: asan.log.2.txt asan.log.1.txt

This patch simply turns the delete calls into delete [].

Testing

Confirmed ASAN doesn't report these errors on tvdir anymore
Confirmed tvdir is operational

magiblot commented 2 years ago

That's right. Thank you.

Could you please amend your commit and remove the space between delete and []? Just to match the style in the pre-existing code.

Cheers.

Michael137 commented 2 years ago

That's right. Thank you.

Could you please amend your commit and remove the space between delete and []? Just to match the style in the pre-existing code.

Cheers.

Done, thanks for reviewing