search

magmo / apps

Proof of concept applications that use the Force Move Game framework.
9 stars 5 forks source link

Buffer overflow in wallet #199

Open tomclose opened 5 years ago

tomclose commented 5 years ago

screen shot 2019-02-12 at 1 05 05 pm

I think this is an overflow of the message queue between the app and the wallet.

lalexgap commented 5 years ago

Looking into this now and I suspect that it might be caused by putting too many block mined events into our channel buffer. (https://github.com/magmo/apps/blob/master/packages/wallet/src/redux/sagas/blockchain-watcher.ts#L10) There are two main places in the wallet we use an eventChannel, the message-listener and the blockchain-watcher. In the message-listener we are already filtering out non-wallet events so I wouldn't expect a buffer overflow to occur there, especially since the message-listener just puts an action whenever it receives a wallet event.

Unfortunately I haven't been able to reproduce this one yet.

@gakonst I was wondering if you have any details about how you ran into it or if you're seeing it consistently?