search

mailgun / groupcache

Clone of golang/groupcache with TTL and Item Removal support
Apache License 2.0
484 stars 72 forks source link

implement batch get service #29

Closed haifeiWu closed 2 years ago

haifeiWu commented 3 years ago

implement batch get service

thrawn01 commented 3 years ago

We shouldn't change the interface, we should instead have the standard interface batch many requests to the same machine if they all come in around the same time. We do this in gubernator which you can see here. https://github.com/mailgun/gubernator/blob/master/peer_client.go#L272-L312

Additionally this feature should be optional, as batching requests means we are trading latency for throughput and some users might care more about latency.

haifeiWu commented 3 years ago

Ok, let me change the way of implementation

thrawn01 commented 2 years ago

closing due to age