Adding Set to Groupcache

mailgun / groupcache

Clone of golang/groupcache with TTL and Item Removal support

Apache License 2.0

484 stars 72 forks source link

Adding Set to Groupcache #31

Closed rneillj closed 2 years ago

tdterry commented 3 years ago

Hi. I've been looking at groupcache recently, and one of the things holding me back was the inability to Set a value. I was just considering how to write it when I found this PR. I think I've found a couple of issues. Do you mind a constructive PR review from someone who's not involved in the project?

thrawn01 commented 3 years ago

@tdterry please do! This first implementation seems trivial, we were just discussing how we go about proving this works in practice.

develar commented 2 years ago

Why it is not yet merged? Not tested changes?

macnibblet commented 2 years ago

This would solve the ticket that I recently opened (#34) what needs to be done for this to be merged?

Happy to help out

thrawn01 commented 2 years ago

This feature is working in production, merging and releasing.