mailgun / groupcache

Clone of golang/groupcache with TTL and Item Removal support
Apache License 2.0
495 stars 73 forks source link

Deadlocks after panic inside Getter #38

Closed costela closed 2 years ago

costela commented 2 years ago

If the Getter's Get method panics, the singleflight mechanism is left in an unclean state (missing a Waitgroup.Done() call), which causes all subsequent Gets of the same key to block indefinitely.

MR with a solution suggestion incoming.