mailgun / groupcache

Clone of golang/groupcache with TTL and Item Removal support
Apache License 2.0
484 stars 72 forks source link

Add HTTP error message from peer to error returned from httpGetter.Get #46

Closed MarnixBouhuis closed 2 years ago

MarnixBouhuis commented 2 years ago

Currently errors returned when making requests to peers only contain the status code returned by the peer. Most of the time this will be a 500 error. The real error reason is returned by the peer in the response body.

This PR adds the error message from the peer to the error returned by the httpGetter.Get method. I've limited the error message to max 10 MiB to limit to prevent possible chaos when peers start returning errors of multiple GB's or something 😃.