mainsail-crew / crowsnest

Webcam Service for multiple Cams
GNU General Public License v3.0
325 stars 78 forks source link

Update moonraker_update.txt to replace missing pkglist.sh #199

Closed twshield closed 1 year ago

twshield commented 1 year ago

pkglist.sh does not exist, guessing install.sh is its replacement

and

install_script:
#  *** DEPRICATED FOR NEW CONFIGURATIONS - USE the 'system_dependencies' OPTION

from https://moonraker.readthedocs.io/en/latest/configuration/

mryel00 commented 1 year ago

Nice to see that you want to contribute but the following will sound pretty rude: The fact about the path is wrong. I think you just have the same problem as #156 You can read about this issue in more detail in #150

guessing install.sh is its replacement

It seems like you just randomly guessed what the correct file could be without looking further into the files and the documentation you sent. The change for this parameter will need a lot more changes and tests, also it doesn't look right to remove a fallback for "older" Moonraker versions. In this context it should be noted this change was made roughly 5 months ago.

Therefore I will close this PR as we would need an actual implementation for this change. We will overhaul the dependencies stuff with the next major release of Crowsnest anyways, so no one should put any efforts in implementing and testing this atm.

As a small side note: tools/install.sh was used with legacy/v3 as you can see here

twshield commented 1 year ago

No problem. Fine with me.

I do my updates on the command line, so did not test this script was correct, as I assumed you would know immediately.

The fact that the pkglist.sh script does not exist keeps Mainsail from showing anything about Crowsnest in the updates section. So what you have in the Crowsnest instructions does not work. So putting any file that exists there solved my problem because all I wanted was to be able to see if there was an update available in Mainsail.

mryel00 commented 1 year ago

So what you have in the Crowsnest instructions does not work.

That's why I posted those two issues. There I explained the problem and posted following commands:

rm -rf ~/crowsnest/tools/pkglist.sh
ln -sf ~/crowsnest/tools/libs/pkglist-rpi.sh ~/crowsnest/tools/pkglist.sh

If you run those, you will fix the broken symlink of MainsailOS. The MainsailOS issue with symlinks is the only currently known problem of missing/wrong tools/pkglist.sh, as the installer of crowsnest will link the files correctly at installation. If your issue is about a not installed repository, then you didn't read the instructions carefully that you linked 😜 Jokes aside, if you want it for a not installed repository, you should run the second command, on a Raspberry Pi, on every other device you should link it to ~/crowsnest/tools/libs/pkglist-generic.sh.

So putting any file that exists there solved my problem

This might be true but can also lead to issues because:

Moonraker will not run this script, instead it will parse the script searching for new "system" package dependencies that require installation.

So if we update the dependencies, you won't get an update of them in the future, if you just write down a random file.

My recommendation: Fix it correctly like written above or it might make you trouble in future

twshield commented 1 year ago

Sorry, should have read those issues. Thanks for spelling it out.