search

mainsail-crew / crowsnest

Webcam Service for multiple Cams
GNU General Public License v3.0
325 stars 78 forks source link

do_memory_split not found in raspi-config #219

Closed jedahan closed 10 months ago

jedahan commented 11 months ago

What happened

raspi-config removed do_memory_split (not sure exactly when, but likely when bookworm was released).

During the install, it failed with the following error

Build 'camera-streamer' ... [SUCCESS]
/usr/bin/raspi-config: 3069: do_memory_split: not found
Trying to set minimum GPU Memory to 160 MB ... [SKIPPED]
    ==> Tool 'raspi-config' not found ...

I am worried the install is now only partially working.

What did you expect to happen

To only run raspi-config do_memory_split when on older versions of raspberry pi OS

How to reproduce

On a fresh version of the latest raspberry pi os:

git clone https://github.com/mainsail-crew/crowsnest
cd crowsnest
sudo make install BASE_USER=$USER

Additional information

No response

jedahan commented 11 months ago

Also the Tool 'raspi-config' not found is a little bit of a misleading error - raspi-config was found, and ran, but errors out.

jedahan commented 11 months ago

https://github.com/mainsail-crew/crowsnest/blob/f7ac6aa298143f0019eae9b2b2be8039196ebeda/tools/libs/set_gpumem.sh#L37

Adding another check for lsb_release or something else might be best. Or just making it a non-fatal error if it isn't already.

mryel00 commented 11 months ago

You are right and I always forget to fix this line of code.... The error is non-lethal as you can see on the yellow [SKIPPED] message. So don't worry, everything should work without problems.