mryel00
commented
6 months ago Hey, first of all thanks for the PR 😄
But now to the problem why I didn't add this myself yet. Did you test this on bullseye? I don't think so. The problem is that we currently are using two different camera-streamer versions. One that got this parameter on bookworm and one without that parameter on bullseye (and sometimes on bookworm).
Now you might think. Just check for bookworm or bullseye then, but we will run into more problems with that. You see, I updated the make update command recently. That will update crowsnest and recompiles ustreamer and camera-streamer. It's doing that by recloning camera-streamer, we got our own reasons for that. One reason can be seen inside #216. That PR is currently a complete mess atm and will be rewritten soon.
But I oversaw one thing doing that change to make update. Currently all distributions download master of camera-streamer.
So now we got people with bullseye on master, those will get problems with that parameter and camera-streamer won't start anymore.
Then we got the bookworm people on main, those will profit from that change.
The last party are people with bookworm on master, as they used make update recently to update and recompile camera-streamer, since there was an update to libcamera. For that they needed an update for camera-streamer and recompile it.
So now we have to run a git branch check to correctly identify the systems to see if that parameter might break something. That's why I didn't yet add that parameter myself, as it's not that hard to just add that one parameter yourself.
With all that you now know on what you should take into account to adjust this PR before I can merge it 😅
P.S. Please use conventional commits as you can also read on the Contribute chapter. This is most important for the PR title
Problem: can't open 8080 outside machine Fix: same behaviour as in ustreamer