search

mainsail-crew / crowsnest

Webcam Service for multiple Cams
GNU General Public License v3.0
302 stars 71 forks source link

fix: support `no_proxy` mode with camera-streamer (bookworm) #238

Closed t3chguy closed 5 months ago

mryel00 commented 5 months ago

@t3chguy Thanks for the PR, but please have a look at my comment from #221 there are all the infos you need, before I can consider to merge it. This is basically a duplicate but I didn't get a response from the OP of that other PR.

t3chguy commented 5 months ago

@mryel00 how about this?

mryel00 commented 5 months ago

Seems fine. I will make a sanity test tomorrow to be sure everything is correct.

t3chguy commented 5 months ago

Actually, looks like one of my printers is running such a version of camera-streamer, and it listens on 0.0.0.0 - so the WARN log is probably not needed.

mryel00 commented 5 months ago

Yes they listen on 0.0.0.0 on the old version and you cannot change that. You are right about the message. As long as it's true that message doesn't make any sense. For false it could make sense, but I don't think it's necessary tbh. So the warning can be deleted.

t3chguy commented 5 months ago

@mryel00 Done.

mryel00 commented 5 months ago

Thank you for the contribution and the fast response time ❤️