search

mainsail-crew / crowsnest

Webcam Service for multiple Cams
GNU General Public License v3.0
324 stars 77 forks source link

added support for Ubuntu 20.04 on armv7l #32

Closed gdachs closed 2 years ago

gdachs commented 2 years ago

Tested on an Odroid C1 with Ubuntu 20.04 on armv7l.

KwadFan commented 2 years ago

Good morning, gdachs!

Thanks for your PR. I would merge it but you have todo a new one please.

Our workflow is a bit different here. master is a Kind of protected branch where we not allow PRs.

Please open a new one against the develop branch.

Also please use conventional commit messages. https://www.conventionalcommits.org/en/v1.0.0/

In this case use 'feat: add support ....'

Would be great if you change that, thanks for testing and fixing.

Regards Kwad

KwadFan commented 2 years ago

To my sadness, you didnt respond to the mentioned changes. I would have like to list you as contrib.

But https://github.com/mainsail-crew/crowsnest/commit/ee59a12d59cb2db173a93b266c4766b853bd0364 should have the same effect.

gdachs commented 2 years ago

To my sadness, you didnt respond to the mentioned changes. I would have like to list you as contrib.

But ee59a12 should have the same effect.

For unknown reason I missed your message. I used this commit only to show you the change. So it is fine if you didn't use it directly.