This PR makes it so that all the events associated with a single transaction are grouped together, so that when processing them we no longer need to manually filter out by looking for Measure events.
A couple of the properties needed to be updated because they depended on seeing intermediate events. In particular:
potChiPieDai no longer needs to track joining parameter. This was because we were double-counting the Vat . move that pot . join triggers, but since that Vat . move is no longer emitted, we don't need to worry about double-counting that joined Dai.
flopBlockCheck can no longer use the Flop . kick call event to update the embers amount, because that is an internal call. Instead, it is relying on the externally visible emitted FlopKick event, which mirrors the Solidity code's custom event for this function.
Overall, I think these properties end up being stated cleaner.
This PR makes it so that all the events associated with a single transaction are grouped together, so that when processing them we no longer need to manually filter out by looking for
Measureevents.A couple of the properties needed to be updated because they depended on seeing intermediate events. In particular:
potChiPieDaino longer needs to trackjoiningparameter. This was because we were double-counting theVat . movethatpot . jointriggers, but since thatVat . moveis no longer emitted, we don't need to worry about double-counting that joined Dai.flopBlockCheckcan no longer use theFlop . kickcall event to update theembersamount, because that is an internal call. Instead, it is relying on the externally visible emittedFlopKickevent, which mirrors the Solidity code's custom event for this function.Overall, I think these properties end up being stated cleaner.