search

makerdao / mkr-mcd-spec

High level KSpecification for the MCD System by Runtime Verification and Maker Foundation
GNU General Public License v3.0
28 stars 9 forks source link

Liq 2.0 #250

Open 0xverif opened 3 years ago

0xverif commented 3 years ago

New K implementations of Abaci, Clip and Dog

0xverif commented 2 years ago

LGTM

Sorry for taking so long @kmbarry1! I formatted my pc since we spoken and so I lost the local fixes I had, the ones I pushed are now completely fixed and compiling

0xverif commented 2 years ago

@ehildenb CI is failing with an OOM error, can you increase the memory allowed?

kmbarry1 commented 2 years ago

LGTM

Sorry for taking so long @kmbarry1! I formatted my pc since we spoken and so I lost the local fixes I had, the ones I pushed are now completely fixed and compiling

No worries! Guess I LGTMed a little prematurely (forgot about what all neeeded fixed), but seems good now.

kmbarry1 commented 2 years ago

Hmmmm merging seems to be blocked on the CI--is this something that should be fixed, or should we just override that requirement and merge on our side @0xverif (it seems this repo is using the RV Jenkins instance)?

0xverif commented 2 years ago

Update: Waiting for help from the K frontend team.