search

makinacorpus / convertit

A generic format conversion Web API in Pyramid
GNU Affero General Public License v3.0
25 stars 10 forks source link

Prepare packaging (zest) #24

Open AntoineCezar opened 11 years ago

AntoineCezar commented 11 years ago

Extracted from issue #17

kiorky commented 11 years ago

related commits : 2f98d9d9a4a37b45bc93da1be68a649b169bc04a 03fae7d9230de01f7af7ca737a4782d454088807 694e173378aea9f6c12d3e8202c81f372a415894

AntoineCezar commented 11 years ago

Great job ! I have just one concern : does the buildout flow needs to break the pyramid flow ? (I've never used buildout)

kiorky commented 11 years ago

What are you calling pyramid flow !?

AntoineCezar commented 11 years ago

I mean not having to learn buildout in a pyramid project. Is there a way to keep the pyramid standard files and folder structure ?

kiorky commented 11 years ago

The only missing files are dev.ini and prod.ini which are generated now via buildout, i readded regenerated ones in b43dd6968c41d4a0c60acfdd07a60051c5cf159d There is no others changes in the distribution.

ghost commented 11 years ago

It really looks like all those buildout boilerplate files don't belong to the project's main source code repository. Seeing things like "apache" in the source code raises a clear sign that this doesn't follow the SoC principle.

Committing an empty var directory seems a bit odd. Surely this can be created when needed. This is why this practice is not supported by git, hence the .empty file hack.

Is there any added value in burying the source code under two levels of directories? I understand that creating the src subdirectory might be motivated by separating application source code from buildout boilerplate files (see my first point), but why src/convertit?

More generally speaking, what would buildout add to the project at this point? Buildout is great for managing non-Python dependencies, but if it's not used that way yet, what's the motivation for using it?

My feeling is that buildout is too intrusive to be hardcoded in the project and I don't see at this point any benefit in introducing tight coupling between a deployment tool and the application source code.

kiorky commented 11 years ago

I ll not go in any debate just do no press the merge button if you dont understand the sense of sain commits. Just burn your wings with some namespaces issues with top level directories in develop mode and you ll never forget to package correctly your distributions with a inner top level directory.

kiorky commented 11 years ago

btw, i just subscribed out notifications, just speak to @leplatrem for anything else.