search

mallgroup / mpapi-client-php

MPAPI client is a PHP tool created to help Internet Mall, a. s. partners easily manage article catalog, deliveries, orders, etc. using Mall Marketplace API.
Apache License 2.0
6 stars 19 forks source link

delivery setters #1

Closed sevcik-poctivaagentura closed 7 years ago

sevcik-poctivaagentura commented 7 years ago

Hello,

I'm not sure about the AbstractDelivery class setters. When I want to set min height to 0, min height key will not be created. I think that there should be if statment in setHeightMin method this way: if ((double) $heightMin !== $this->getHeightMin() || !isset($this->data[self::KEY_HEIGHT][self::KEY_MIN])) and also for setLengthMin should be: if ((double) $lengthMin !== $this->getLengthMin() || !isset($this->data[self::KEY_LENGTH][self::KEY_MIN]))

This way it works for me, but I'm not sure about another dependencies.

Best Regards, Jan Sevcik

janblahamall commented 7 years ago

Hi, thanks for your report. We fixed the problem in new release: https://github.com/mallgroup/mpapi-client-php/tree/v1.9.4