malllabiisc / CompGCN

ICLR 2020: Composition-Based Multi-Relational Graph Convolutional Networks
Apache License 2.0
597 stars 107 forks source link

Just a small suggestion. #10

Closed seanswyi closed 4 years ago

seanswyi commented 4 years ago

Hello. This is just a personal suggestion that I had rather than an issue with the code itself.

I think that it may be helpful for future users if you specified in the README that users should first create ./log/, ./data/, and ./checkpoints/ files before running the code. It's not a big deal, but it would be a bit better user experience IMO.

Thanks.

soumyasanyal commented 4 years ago

Please check out the preprocess.sh file. We already have those commands as a preprocessing step. We expect new users to follow all the steps mentioned in the README before they run the python command. We will make this more explicit in the README.