manatlan / guy

Graphics User Ynterface : a simple module for making GUI applications (with html/js) for py3 ... to target windows, linux, mac & android
Apache License 2.0
203 stars 23 forks source link

DEBUG on by default #12

Closed icarito closed 4 years ago

icarito commented 4 years ago

Hi, It was driving me crazy in latest guy debugging logging was on. I managed to change setting to setLevel(logging.ERROR) in guy.py. But this should be off by default and a configurable setting documented. Thanks for your work!

manatlan commented 4 years ago

Hi .... I don't understand .... In current release (and olders) : "debugging" is off by default ... to enable it, you should set "log=True" when calling .serve(), .run() .... no ?

icarito commented 4 years ago

No, debugging is on by default, at least in Guy version 0.5.3 which is what I'm using. I disabled it in guy.py locally by editing line 57 from DEBUG to ERROR.

El mar, 7 de abr de 2020 a las 23:57, manatlan notifications@github.com escribió:

Hi .... I don't understand .... In current release (and olders) : "debugging" is off by default ... to enable it, you should set "log=True" when calling .serve(), .run() .... no ?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/manatlan/guy/issues/12#issuecomment-610786010, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABQYS7K2UOS2FL3F3ORI63RLQN43ANCNFSM4MCFWOCA.

icarito commented 4 years ago

Here, it changed 2 months ago:

https://github.com/manatlan/guy/commit/67854cfe811b0233e06b880dded9e70587a5d297

:-)

Thanks for Guy!

El mié, 8 de abr de 2020 a las 02:00, Sebastian Silva sebastian@fuentelibre.org escribió:

No, debugging is on by default, at least in Guy version 0.5.3 which is what I'm using. I disabled it in guy.py locally by editing line 57 from DEBUG to ERROR.

El mar, 7 de abr de 2020 a las 23:57, manatlan notifications@github.com escribió:

Hi .... I don't understand .... In current release (and olders) : "debugging" is off by default ... to enable it, you should set "log=True" when calling .serve(), .run() .... no ?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/manatlan/guy/issues/12#issuecomment-610786010, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABQYS7K2UOS2FL3F3ORI63RLQN43ANCNFSM4MCFWOCA.

manatlan commented 4 years ago

and ... is the 0.5.5 right for you ?

icarito commented 4 years ago

I'll check it and let you know! Didn't find a release or a tag in the repo so I guess from NPM?

El mié, 8 de abr de 2020 a las 00:20, manatlan notifications@github.com escribió:

and ... is the 0.5.5 right for you ?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/manatlan/guy/issues/12#issuecomment-610794738, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABQYS6X7ATCUVYLYC6C6R3RLQQSRANCNFSM4MCFWOCA.

manatlan commented 4 years ago

The 0.5.5 is on GitHub & https://pypi.org/project/guy/

icarito commented 4 years ago

Yeah sorry I meant Pypi not npm!

El mié, 8 de abr de 2020 a las 03:40, manatlan notifications@github.com escribió:

The 0.5.5 is on GitHub & https://pypi.org/project/guy/

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/manatlan/guy/issues/12#issuecomment-610884677, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABQYS6YTGOOJR5GXBYE6DTRLRIDRANCNFSM4MCFWOCA.

icarito commented 4 years ago

I just tried it and it still exhibits the same flaw!

For what it's worth, my code lives at https://gitlab.com/fuentelibre/super-8/ and is deployed (with the workaround described) at https://super-8.educa.juegos/

El mié, 8 de abr de 2020 a las 05:48, Sebastian Silva sebastian@fuentelibre.org escribió:

Yeah sorry I meant Pypi not npm!

El mié, 8 de abr de 2020 a las 03:40, manatlan notifications@github.com escribió:

The 0.5.5 is on GitHub & https://pypi.org/project/guy/

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/manatlan/guy/issues/12#issuecomment-610884677, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABQYS6YTGOOJR5GXBYE6DTRLRIDRANCNFSM4MCFWOCA.

manatlan commented 4 years ago

I just tried it and it still exhibits the same flaw!

I don't understand what is this flaw ...

icarito commented 4 years ago

Here's a simple program that causes debugging messages to appear on button press:

from guy import Guy

class ShowFlaw(Guy):
    """
    <button onclick="self.show_flaw()">PUSH</button>
    (and see the javascript console debugging)
    """

    def show_flaw(self):
        return "This will log into javascript console."

ShowFlaw().run()
icarito commented 4 years ago

And here's the JS console: image

This is with Guy 0.5.5.

manatlan commented 4 years ago

the 0.5.6 fix that issue (here & on pypi)