search

manelferreira / serverless-sequelize-migrations

A Serverless plugin to manage sequelize migrations
MIT License
21 stars 17 forks source link

Added support for SQL connection string #20

Closed stevan-tosic closed 4 years ago

stevan-tosic commented 4 years ago

When using AWS SSM some users would like to use DB_CONNECTION_URL instead of passing all DB parameters.

This feature has an Open Closed approach which means that users of the previous version will not have issues with the new version.

All tests are passing and code lint has no errors.

manelferreira commented 4 years ago

Hi @toskadv , how are you?

Thank you very much for your contribution, i found it very interesting.

I have merged your branch on master earlier today. Also, I have just committed a little refactoring I did on the function that builds the connection URL. If you are interested, take a look at it and tell me what you think.

I'll be publishing a new version of the package on npm right now.

Again, thank you very much!

stevan-tosic commented 4 years ago

Hi @manelferreira

You are welcome, I am excellent after knowing that PR is approved.

I also took look into your additional changes and only I can say that code now is way much better and easier to understand.

I saw npm package version changes and will use the new version in the project.

If there is a need you can find me at the next links: LinkedIn StackOverflow

Best regards, Stevan Tosic